Second line of address of person is not added to eml

[jlaundre]

The second line of a person's address is not added to the eml address field.

[jlaundre]

Eml person address is missing 2nd line of address

Eml output only the first line of the address stored in the person content. Need to add code in eml module eml.field.inc to check if there is a second line and then concatenated the two, separating them by a comma.

    if (!empty($item['premise'])) {
      $address['deliveryPoint'] = $address['deliveryPoint'].", ".$item['premise'];  
    }

[isangil]

makes sense

On Wed, Feb 28, 2018 at 10:09 AM, jlaundre notifications@github.com wrote:

Eml person address is missing 2nd line of address

Eml output only the first line of the address stored in the person content. Need to add code in eml module eml.field.inc to check if there is a second line and then concatenated the two, separating them by a comma.

if (!empty($item['premise'])) {
  $address['deliveryPoint'] = $address['deliveryPoint'].", ".$item['premise'];
}

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/lter/deims/issues/154#issuecomment-369306463, or mute the thread https://github.com/notifications/unsubscribe-auth/AAYmjzoS5jqgAFJn06Ykfrj7wluaM9ZBks5tZYXEgaJpZM4MA5ES .

[isangil]

do you wanna write a patch & make a pull request? ill be happy to review and commit

[jlaundre]

Hi Inigo,

Yes I will. I have been working on getting a number of fixes in github, e.g. http://arc-lter.ecosystems.mbl.edu/repopulating-cachelterunit-table And in EmlDataSet.php adding utf8 option to tidy statement at line 80, i.e. $tidy->repairString($xml, $config,'utf8') for &nbsp problem.

Jim

From: Inigo San Gil [mailto:notifications@github.com] Sent: Wednesday, February 28, 2018 1:36 PM To: lter/deims deims@noreply.github.com Cc: James Laundre jlaundre@mbl.edu; Author author@noreply.github.com Subject: Re: [lter/deims] Second line of address of person is not added to eml (#154)

do you wanna write a patch & make a pull request? ill be happy to review and commit

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/lter/deims/issues/154#issuecomment-369337952, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFlMqhUzEGx74FbS3seW3tjJi9-XErL2ks5tZZyggaJpZM4MA5ES.

[jlaundre]

No more comments from users