lter / lterwg-som

Soil Organic Matter Synthesis working group
https://lter.github.io/som-website/
8 stars 6 forks source link

Update givenUnits in keyV2 to match unit conversion in soilHarmonization #65

Closed piersond closed 5 years ago

piersond commented 5 years ago

There are currently many mismatches. Does not appear to be a homogenization issue, simply an issue for providing the correct information to users across all tables/platforms.

Use unitsConversions %>% print(n = Inf) with the pkg loaded to see the units conversions that the soilHarmonization pkg is using.

Also need to update the units in the key table we're using for the Shiny app.

srearl commented 5 years ago

Derek - can you point out some examples for me?

piersond commented 5 years ago

@srearl I can handle this, just wanted to keep you informed. The issue is to fix the unit discrepancies between the soilHarmonization end units, the keyV2_template and the Shiny app data info table. There are currently a handful of differences in units between the three.

I'll be using the soilHarmonization unit table as the master, from which to check/correct the units in the other two tables. Is that the correct way to go?

piersond commented 5 years ago

Fixed. However, best to continue keeping a close eye on units across project components.