search

lter / soilHarmonization

Homogenize LTER Soil Organic Matter Working Group data and notes
https://lter.github.io/soilHarmonization/
Other
1 stars 4 forks source link

soft fail on QC #16

Closed wwieder closed 5 years ago

wwieder commented 5 years ago

make soft fail with log on homog QC criteria

srearl commented 5 years ago

Only able to work on this in small chunks so apologies for my slowness. This is ready for testing.

data_homogenization() has been modified such that failed QC checks are logged but do not abort. QC errors are now noted on the screen at run time and in a revised notes file. The notes file now exports to PDF. You will likely need to have LaTeX installed on your machines to facilitate the export to PDF.

Checks to ensure that (1) the user is using a key file version 2, and (2) all required key file parameters are included will still cause a fail if not passed.

@wwieder @piersond

piersond commented 5 years ago

@srearl Awesome Stevan! I've got a chunk of time tomorrow to test it out. I'll report back.

wwieder commented 5 years ago

I'm on spring break this week, but will start in on this in April... finally!

On Wed, Mar 27, 2019 at 2:43 PM Derek Pierson notifications@github.com wrote:

@srearl https://github.com/srearl Awesome Stevan! I've got a chunk of time tomorrow to test it out. I'll report back.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/srearl/soilHarmonization/issues/16#issuecomment-477339705, or mute the thread https://github.com/notifications/unsubscribe-auth/AHqLJBhl9lOx6jpAwy0rSTYDrXkemuSxks5va9fmgaJpZM4bhxFW .

-- Will Wieder Project Scientist CGD, NCAR 303-497-1352

wwieder commented 5 years ago

min values for n_min and n_nit can be < 0 when net N immobilization is occurring. This may not really be an issue with soft fail.

srearl commented 5 years ago

Since this is only reporting and not throwing an error, seems like it would be reasonable to keep this information in the report. I am going to close this for now but we can definitely revisit it if the justifiable negative values create any confusion.