lter / soilHarmonization

Homogenize LTER Soil Organic Matter Working Group data and notes
https://lter.github.io/soilHarmonization/
Other
1 stars 4 forks source link

root biomass #27

Closed wwieder closed 4 years ago

wwieder commented 5 years ago

This is related to #26, but NEON data are provided in mg DW cm^-2 with separate root %C that can be used to convert to gC m^-2, the target unit for bgb. How much other root biomass data to we have from other sites besides NEON? Are they typically location or profile data? I wonder if we should revisit how we're handling these data in the key-key?

wwieder commented 4 years ago

More confusing now is that Samantha noticed the target units for bgb on the shiny app seem to be kg/m2? Lot's of errors being thrown for NEON periodic roots. @srearl, maybe worth a call to brainstorm here?

wwieder commented 4 years ago

The bulk of our bgb data are coming from NutNet and NEON, which both report values in gDM/m2 (or mgDM/cm2). Other sites that treat this similarly are CDR, UMBS DIRT, BOUSSON DIRT.

Exceptions are the AND reference stands, which reported as in mass C units per area

wwieder commented 4 years ago

Can we add a units provided for bgb to gDM cm-2 (for Bousson). And the conversions to get to target unit.

wwieder commented 4 years ago

Suggesting we move the target for bgb to gDW/m2. Only two sites HBR and AND provided data in gC/m2. Let's multiply these by 2 to get back to gDW/m2. All other sites are already in DW units, but we'll still have to convert to appropriate units for mass and area.

srearl commented 4 years ago

Will - I am stuck not being able to test this because of that darn duplicated Google ID or whatever it is that is confounding by connection between R and Google. Please give the branch below a try. We will have to keep in mind that the units conversion update in the script is now out of sync with both the key file version 2 and the key file update script. Also, am super nervous that we are changing the target units at this stage so we really need to be cautious.

https://github.com/srearl/soilHarmonization/tree/units-conversion-update

cc @piersond

wwieder commented 4 years ago

Conversions seem to be good. I hope we can be done using the update key file script. I think everything should be Key_V2 now. What does the key file version 2 do?

srearl commented 4 years ago

These conversions have been added to the package units conversion table; adding the units as a drop-down in the key file is, likely, a version 3 feature so closing this for now.