search

ltfat / phaseret

Phase ReTrieval for time-frequency representations
http://ltfat.github.io/phaseret
GNU General Public License v3.0
48 stars 12 forks source link

pv done right #13

Open timprepscius opened 1 year ago

timprepscius commented 1 year ago

Hey there,

Could you give me an impression of the performance of pvdoneright, or demo_phasevocoder.m?

For instance given 1 second of sound, on your computer that you you have in front of you, how long does it take to speed up to 0.9 it's length? (Obviously you don't have 1 second of sound right in front of you, so rough estimate is fine)

I'm currently installing octave- but I think it will be several hours of fiddling before things run on my end :-(. Or maybe it won't run at all actually.

I'm considering porting to C++, if the general performance is adequate for my needs (should be realtime or better than realtime). There is an implementation in rust, however it is ... not optimal.

Thanks,

-tim

nholighaus commented 1 year ago

The code is capable of faster than real-time processing on a modern PC out of the box and most of the code is already in the C. I think rather than porting the C code to C++ it would probably make more sense to streamline the existing C code for whatever your purpose is.

There is probably some optimization possible to aspects of the algorithm itself, e.g., managing heap size, for further speedup, but those would be up to you.

timprepscius commented 1 year ago

Ah, I didn't even notice the C code.

Unfortunately, I can't use GPL. So I'll have to implement another version.

Thank you for the information regarding efficiency.

On 1/16/23, nholighaus @.***> wrote:

The code is capable of faster than real-time processing on a modern PC out of the box and most of the code is already in the C. I think rather than porting the C code to C++ it would probably make more sense to streamline the existing C code for whatever your purpose is.

There is probably some optimization possible to aspects of the algorithm itself, e.g., managing heap size, for further speedup, but those would be up to you.

-- Reply to this email directly or view it on GitHub: https://github.com/ltfat/phaseret/issues/13#issuecomment-1383691997 You are receiving this because you authored the thread.

Message ID: @.***>