ltgcgo / octavia

🎻 Event-driven multi-standard MIDI state-tracking library.
https://gh.ltgc.cc/octavia/
GNU Lesser General Public License v3.0
41 stars 7 forks source link

GS receive channel 0x10 means "receive off" #21

Closed PoneyClairDeLune closed 11 months ago

PoneyClairDeLune commented 1 year ago

When receive channel of a part on GS set to 16 (0x10), it means receiving for that channel is disabled entirely, instead of "channel 17". Crucial for correct CM-64 support.

Thanks @valleybell for sending the file, which helped spot the issue!

PoneyClairDeLune commented 11 months ago

Addressed in https://github.com/ltgcgo/octavia/commit/b329e8e5fa77175aa6b3ef9ea261720f295c5fea .