ltgoslo / norbench

Natural language understanding benchmarks for Norwegian
MIT License
14 stars 4 forks source link

Downloading datasets in all_tasks script does not work? #7

Closed akutuzov closed 1 year ago

akutuzov commented 1 year ago

The download_cur_data argument in the all_tasks.py script behaves a bit weirdly.

  1. A user reasonably expects it's enough to simply append --download_cur_data to the command, and the datasets will be downloaded automatically. Instead, the script crashes with all_tasks.py: error: argument --download_cur_data: expected one argument

  2. If instead --download_cur_data True is used, the script still crashes, this time with

    File "all_tasks.py", line 120, in <module>
    raise Exception(f'Check paths "{path_tsk}" to data for {tsk} task')
    Exception: Check paths "" to data for pos task

I believe boolean arguments should be implemented with BooleanOptionalAction.