search

lthibault / quic-mangos

A QUIC transport for mangos (scalability protocols) written in pure Go
Apache License 2.0
24 stars 2 forks source link

Update import path for mangos. #7

Open iwasaki-kenta opened 5 years ago

iwasaki-kenta commented 5 years ago

Hello,

I was looking to do some benchmarks for your transport package, though noticed that the import paths are outdated (they reference the master Github branch of mangos v2 instead of the official mangos v2 import URL).

Some discussions on it were done here: https://github.com/iwasaki-kenta/mangos-benchmark/issues/1

Would it be possible to have the import URLs updated to point to here: nanomsg.org/go/mangos/v2?

lthibault commented 5 years ago

Hello, indeed you're right! If you want to submit a PR, I can get this merged today. Otherwise it might take me a few weeks to get to this.

egorsmkv commented 5 years ago

Hey guys, I started to do the PR but it seems that the API has breaking changes.

After replacing the URL I had test issues:

# github.com/egorsmkv/quic-mangos [github.com/egorsmkv/quic-mangos.test]
./dialer.go:89:9: undefined: mangos.NewConnPipe
./listener.go:135:9: undefined: mangos.NewConnPipe
./quic.go:24:64: undefined: mangos.PipeDialer
./quic.go:40:66: undefined: mangos.PipeListener
./mock_test.go:69:36: undefined: quic.ConnectionState
./mock_test.go:69:66: undefined: quic.ConnectionState
./quic_test.go:28:9: impossible type assertion:
    *dialer does not implement mangos.TranDialer (wrong type for Dial method)
        have Dial() (mangos.Pipe, error)
        want Dial() (mangos.TranPipe, error)
./quic_test.go:60:9: impossible type assertion:
    *listener does not implement mangos.TranListener (wrong type for Accept method)
        have Accept() (mangos.Pipe, error)
        want Accept() (mangos.TranPipe, error)
FAIL    github.com/egorsmkv/quic-mangos [build failed]

So, it needs more time to refactor tests and, I suppose, the code.