search

lthoerner / betteranvils

A Spigot plugin to bring the anvil into the modern age of Minecraft
GNU General Public License v3.0
3 stars 0 forks source link

Tried adding to my server with Ecoenchants #3

Open pajamaben opened 1 year ago

pajamaben commented 1 year ago

I use EcoEnchants on my server, and when combining custom enchantment books, it throws a huge error message in the console, when adding items with the enchantments applied results in this message: "Incompatible enchantments detected for item DIAMOND_CHESTPLATE"

lthoerner commented 1 year ago

Hey @pajamaben, thanks for trying out BetterAnvils!

Because much of the code on this plugin relies on very static values, it is currently not compatible with custom enchantment plugins. If you would like to convert this to a feature request, we can absolutely look into it.

In terms of the error message, I realize now that I should have made a configuration option to turn off warnings like this. I will push release 0.1.2 in the next few hours where this option is disabled by default.

pajamaben commented 1 year ago

I figured this was the case, but from what I could see with my limited testing it did add them together on the anvil correctly, I didn't test the effects after I found the error but I'm assuming since the enchantment still showed correctly that it did work and Ecoenchantments still picked it up since since it's still on the item

lthoerner commented 1 year ago

That's interesting. I'm not sure what would allow EcoEnchants books to bypass the BetterAnvils anvil logic, unless they are somehow integrated with the vanilla enchantments in such a way that they are indistinguishable (books with stored Enchantments and an EnchantmentStorageMeta).