Crash after rebasing at interactive_ui_tests

[ryumiel]

• out/Debug/interactive_ui_tests --no-sandbox --single_process --gtest_filter=SidebarTest.*

Crashes at SidebarTest::ShowSidebar(WebContents* temp, const std::string& testpage), Due to the null host in SidebarContainer. We need to check initialization sequence of SidebarContainer and SidebarManager

[ryumiel]

Unable to find Extension* from ExtensionSet::GetByID

const Extension* ExtensionSet::GetByID(const std::string& id) const { ExtensionMap::constiterator i = extensions.find(id); if (i != extensions_.end()) return i->second.get(); else return NULL; }

[ryumiel]

Wrong extension_id at const Extension* GetExtensionForUrl(Profile* profile, const GURL& url) causes NULL extension

Expected

Name : extension_id Details:{static npos = 18446744073709551615, _M_dataplus = {std::allocator = {<__gnu_cxx::new_allocator> = {}, }, _M_p = 0x1eacbe188b98 "ncgnpfebcfncmafojeeknfilnahcakfe"}}

Actual:

Name : extension_id Details:{static npos = 18446744073709551615, _M_dataplus = {std::allocator = {<__gnu_cxx::new_allocator> = {}, }, _M_p = 0x3d3e71555758 "127.0.0.1"}}

[ryumiel]

ExtensionViewHost tries to load extension but if we passes empty or invalid url, it refuses to load

It looks like we have to use TestExtensionDir and load extension inside of that to generate proper extension for test.

That's quite interesting that we already have contentid in sidebar_browsertest but we construct ExtensionViewHost using just URL, contentid only used for managing extensions inside of sidebar_manager.

To follow convention in ExtensionViewHost, we should use same scheme with other extensions like popup or dialog.

[ltilve]

Fixed at https://github.com/ltilve/chromium/commit/52812d07634a3d30ad732ec96cd388f53e45d952