Consider avoiding NOTIFICATION_SIDEBAR_CHANGED

ltilve / chromium

Chromium.org open source browser project, git cloned from http://git.chromium.org/chromium/src.git

BSD 3-Clause "New" or "Revised" License

0 stars 0 forks source link

Consider avoiding NOTIFICATION_SIDEBAR_CHANGED #18

Closed ltilve closed 9 years ago

ltilve commented 9 years ago

By https://codereview.chromium.org/1152613003/diff/20001/chrome/browser/chrome_notification_types.h#newcode343

We're working "hard" (read: we really want to, but bandwidth is hard to come by) to deprecate notifications, so it'd be best to avoid adding any more, if we can.

ryumiel commented 9 years ago

It is removed from Mac port by 39964ab39d67bf87d1d44b5c9035a2cb578a1a33

ltilve commented 9 years ago

It has been possible to replace the usage of a notification for the sidebar change at https://github.com/ltilve/chromium/commit/606ffb56d780a448b38fe8b1a44520c227c788a6