search

ltilve / chromium

Chromium.org open source browser project, git cloned from http://git.chromium.org/chromium/src.git
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Remove extension_sidebar_*.[h|cc] from browserAction CL #2

Closed ryumiel closed 9 years ago

ryumiel commented 9 years ago

Those classes should not placed in extensions/common, because these functionality are only related to sidebar_api and sidebar_manager

extensions/common/extension_sidebar_defaults.cc | 18 + extensions/common/extension_sidebar_defaults.h | 29 + extensions/common/extension_sidebar_utils.cc | 37 + extensions/common/extension_sidebar_utils.h | 29 +

ryumiel commented 9 years ago

It is done at 218a91a028aa75038bc57388b86a93c87148469e (API side) but need more clean up for browserAction CL.

ryumiel commented 9 years ago

I decided to remove this classes, because its functionality can be covered inside of sidebar_api classes.