Disable support of content_id_to_sidebar_container mapping

ltilve / chromium

Chromium.org open source browser project, git cloned from http://git.chromium.org/chromium/src.git

BSD 3-Clause "New" or "Revised" License

0 stars 0 forks source link

Disable support of content_id_to_sidebar_container mapping #20

Closed ltilve closed 9 years ago

ltilve commented 9 years ago

From https://codereview.chromium.org/1152613003/diff/40001/chrome/browser/extensions/sidebar_manager.cc?context=10&column_width=80&tab_spaces=8

I don't think we should support multiple sidebars in a single tab - it's wasteful with web contents, and this "active/inactive" stuff complicates the code a lot. Why not just have it behave similar to popups (though on a per-tab basis) - you can have one sidebar open at a time, and if you open another, it closes the first (completely)?

ltilve commented 9 years ago

There were still some functions that could be removed as we were not allowing multiple sidebars. Fixed at https://github.com/connectifier/chromium/compare/00776533013d884fd...3b704a378271d593343d569d9b2cd89982a8dc11