search

ltilve / chromium

Chromium.org open source browser project, git cloned from http://git.chromium.org/chromium/src.git
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Merge ExtensionActionViewController logic and tests clicking actions #24

Closed ltilve closed 9 years ago

ltilve commented 9 years ago

https://codereview.chromium.org/1168383002/#msg5

You should also include the logic from ExtensionActionViewController, since that class is platform-agnostic, and does not require a real view - thus it's part of the "core" logic. Then, we can have a slightly more intensive test, like clicking on actions in order to open/close sidebars.

ltilve commented 9 years ago

Fixed by https://github.com/ltilve/chromium/commit/f5c4f7878ee88a617cc36a950230de4da6ad3a59 https://github.com/ltilve/chromium/commit/1a59c9e3ff31e3c3d2808b841bf7669b25fc879c and https://github.com/ltilve/chromium/commit/d621d540b99122c9779f0982fe3c912dfbc31587