search

ltilve / chromium

Chromium.org open source browser project, git cloned from http://git.chromium.org/chromium/src.git
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Use only a WebContents* to SidebarContainer* map #26

Closed ltilve closed 9 years ago

ltilve commented 9 years ago

https://codereview.chromium.org/1168383002/diff/60001/chrome/browser/extensions/sidebar_manager.h#newcode95

Having two maps is probably excessive, since most users won't have that many sidebars open, and keeping everything up to date is a bit of a pain. I'd just have one map, keyed on web contents, and then if you need to look up a particular sidebar, you can just traverse it (since it will be small).

ltilve commented 9 years ago

Fixed at https://github.com/ltilve/chromium/commit/3188bf929fb9ff4153e94fc50430e6f1939da136