search

ltilve / chromium

Chromium.org open source browser project, git cloned from http://git.chromium.org/chromium/src.git
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Assertion failures when opening / closing sidebar in debug mode #30

Closed ryumiel closed 9 years ago

ryumiel commented 9 years ago

AddObserver should be done at construction time of ExtensionActionViewController, to match with RemoveObserver in destructor of ExtensionActionViewController. So we need to remove AddObserver from TriggerPopupWithUrl

It is handled at cd41a1e0c4f461d01b75a5ec425eab20787bbf10

Also, We need to handle popupowner of ToolbarActionBar properly.

ltilve commented 9 years ago

https://github.com/ltilve/chromium/commit/90915d231aadf0d9974d7e2c0e910234c4f7b46a and https://github.com/ltilve/chromium/commit/a85c9431371a293fc063b5ec84321a9040a02cd3 Merged with the rest of the refactoring