search

ltilve / chromium

Chromium.org open source browser project, git cloned from http://git.chromium.org/chromium/src.git
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Fix comments on overflown issues and is_showing_sidebar() changes #33

Closed ltilve closed 9 years ago

ltilve commented 9 years ago

Fixing addressed reviews at https://codereview.chromium.org/1168383002/#msg13

ltilve commented 9 years ago

The following commits fix the initial comments wrt the tests and overflow behaviour https://github.com/ltilve/chromium/commit/f2949bff8e7555b547d35c8748baed8216947918 https://github.com/ltilve/chromium/commit/0f400768b68dbf186ccd8a744cebeef7bb430dd4

ryumiel commented 9 years ago

Change about refactoring is uploaded at 605ddfebb24719dbcaa13afe4dcf536a33c4e994 (including is_showing_sidebar)

ryumiel commented 9 years ago

As mentioned in below commit, is_showingsidebar was reverted. e97b374c3de386d45d57e279faf7870fce8a75f6

Now we are ready to send a CL

ltilve commented 9 years ago

All the comments have been handled and pushed https://codereview.chromium.org/1168383002/#msg14