search

ltilve / chromium

Chromium.org open source browser project, git cloned from http://git.chromium.org/chromium/src.git
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Use extension's toolbar button depressed for attribution #4

Closed ltilve closed 9 years ago

ltilve commented 9 years ago

As only one sidebar can be shown at once, it's enough for making explicit the extension responsible for it.

ltilve commented 9 years ago

Keeping the toolbar button depressed can be done by

view_delegate_->OnPopupShown(grant_tab_permissions);

However, it might be necessary to do some refactoring to be able to receive the notification when the sidebar is closed/hidden to release the depressed state.

ltilve commented 9 years ago

The following commits refer to this bug: https://github.com/ltilve/chromium/commit/9aacd197254dfb2d00260bfe047db31fe828ce84 and https://github.com/ltilve/chromium/commit/1e30da2a4b0d2a46e0d06f26509ae3ed41f87b78

ltilve commented 9 years ago

The commits fffaadadf91 and 4dc12934f5c solve problems happening with "multiple windows / multiple tabs" and "one window / multiple tabs" respectively.

ltilve commented 9 years ago

Ported the patches to browserAction branch https://github.com/ltilve/chromium/commit/a5a7f1ed30c2efec294644a8137341265190574d https://github.com/ltilve/chromium/commit/ae96756a46143fedc376c8ce6bf0d2c0b2fd1340