ryumiel
commented
9 years ago Crash was fixed by 05090c9e444d73a863990787802ba8727e63ef6e, but one test is failing:
../../chrome/browser/ui/cocoa/browser_window_controllerunittest.mm:701: Failure Value of: [[controller tabContentArea] isOpaque] Actual: true Expected: false [ FAILED ] BrowserWindowControllerTest.TestSplitViewsAreNotOpaque (77 ms) [ RUN ] BrowserWindowControllerTest.BookmarkBarHitTest [ OK ] BrowserWindowControllerTest.BookmarkBarHitTest (70 ms) [----------] 7 tests from BrowserWindowControllerTest (679 ms total)
[----------] Global test environment tear-down [==========] 7 tests from 1 test case ran. (679 ms total) [ PASSED ] 6 tests. [ FAILED ] 1 test, listed below: [ FAILED ] BrowserWindowControllerTest.TestSplitViewsAreNotOpaque
1 FAILED TEST
$ ./out/Release/unit_tests --single-process --gtest_filter=BrowserWindowControllerTest*
[ RUN ] BrowserWindowControllerTest.TestSplitViewsAreNotOpaque 2015-04-21 16:10:45.261 unit_tests[49694:1591922] -[SidebarController view]: unrecognized selector sent to instance 0x7ff88e855b30 [49694:1299:0421/161045:79539930151365:FATAL:chrome_browser_application_mac.mm(159)] Someone is trying to raise an exception! NSInvalidArgumentException reason -[SidebarController view]: unrecognized selector sent to instance 0x7ff88e855b30 [11/17] BrowserWindowControllerTest.TestResizeViewsWithBookmarkBar (171 ms) [12/17] BrowserWindowControllerTest.BookmarkBarIsSameWidth (79 ms) [13/17] BrowserWindowControllerTest.TestTopRightForBubble (70 ms) [14/17] BrowserWindowControllerTest.TestZoomFrame (116 ms) [15/17] BrowserWindowControllerTest.TestFindBarOnTop (84 ms) [16/17] BrowserWindowControllerTest.TestSplitViewsAreNotOpaque (CRASHED) Note: Google Test filter = BrowserWindowControllerTest.BookmarkBarHitTest [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from BrowserWindowControllerTest [ RUN ] BrowserWindowControllerTest.BookmarkBarHitTest [ OK ] BrowserWindowControllerTest.BookmarkBarHitTest (150 ms) [----------] 1 test from BrowserWindowControllerTest (151 ms total)
[----------] Global test environment tear-down [==========] 1 test from 1 test case ran. (151 ms total) [ PASSED ] 1 test. [17/17] BrowserWindowControllerTest.BookmarkBarHitTest (150 ms) 1 test crashed: BrowserWindowControllerTest.TestSplitViewsAreNotOpaque Tests took 2 seconds.