ltog
commented
8 years ago @flohoff : The diff you pasted looks crippled: There is no further text after #include... You might want to surround such text/code using tripple backticks as described in https://help.github.com/articles/basic-writing-and-formatting-syntax/#quoting-code .
Are you sure you are using the latest version of osmi-addresses and libosmium? You will find the latest version osmi-addresses in branch master. As far as I understand the error message it refers to the line google::protobuf::ShutdownProtobufLibrary(); that I removed about half a year ago in https://github.com/ltog/osmi-addresses/commit/2bd4fe248ad2b17967a4892e9385f6d7cd2b5158 .
Note that Google Protobuf and OSMPBF aren't dependencies of libosmium anymore: https://github.com/osmcode/libosmium/wiki/Libosmium-dependencies#google-protocol-buffers-until-version-22
flohoff
Hi, in main.cpp you use some google::protobuf methods without including stubs. Compile fails for me on Jessie with current osmi + libosmium:
g++ -I../../libosmium/include/ -O3 -std=c++11 -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DOSMIUM_WITH_SPARSEHASH=1 -Wall -Wextra -pedantic -Wredundant-decls -Wdisabled-optimization -Wctor-dtor-privacy -Wnon-virtual-dtor -Woverloaded-virtual -Wsign-promo -Wold-style-cast -I/usr/include/gdal -o osmi main.cpp -lexpat -pthread -lz -lprotobuf-lite -losmpbf -lz -lbz2 -L/usr/lib -lgeos-3.4.2 -L/usr/lib -lgdal -lboost_program_options -lboost_filesystem -lboost_system ; touch last_use_of_gcc.tmp main.cpp: In function ‘int main(int, char**)’: main.cpp:91:10: error: ‘google::protobuf’ has not been declared google::protobuf::ShutdownProtobufLibrary();
I added
diff --git a/osmi/main.cpp b/osmi/main.cpp index 8a1eef4..0fa4a35 100644 --- a/osmi/main.cpp +++ b/osmi/main.cpp @@ -1,6 +1,8 @@
include
include
+#include <google/protobuf/stubs/common.h> +
pragma GCC diagnostic push
pragma GCC diagnostic ignored "-Wold-style-cast"
pragma GCC diagnostic ignored "-Wredundant-decls"
which worked for me ...
Flo