search

ltog / osmi-addresses

Calculates the Address view of the OSM Inspector
Boost Software License 1.0
11 stars 4 forks source link

Support roads with ref=* #117

Closed blackboxlogic closed 2 years ago

blackboxlogic commented 4 years ago

Regarding: https://github.com/ltog/osmi-addresses/blob/cdae6e10d809b10ff7ea456eee41922d90f87f48/osmi/FirstHandler.hpp#L122

I went looking for how you match addr:street to highways and was pleased that you use variations on the name tag like official_name. Consider also including the ref tag which is "common for roads" (like "US 1") and when a name would only be duplicating the information in the ref=* tag, then the ref and noname=yes is appropriate.

blackboxlogic commented 4 years ago

Also consider removing name_1 since it is deprecated. And adding short_name.

blackboxlogic commented 4 years ago

Would you consider a pull request on this if I made one?

ltog commented 4 years ago

@blackboxlogic : Do you have a source for name_1 being deprecated?

@Nakaner , @woodpeck : What do you think?

woodpeck commented 4 years ago

https://wiki.openstreetmap.org/wiki/Names#Deprecated_tags says that number suffixes are deprecated. I think that it would make sense to drop name_1.

Nakaner commented 4 years ago

name_1 comes from iD users using the raw tag editor in iD (not the presets). If a user added name=something and then adds name=anything else in a row below, the second name is changed to name_1 automatically because keys are unique per OSM object. I think we should join the other editors (namely JOSM) which tell their users that they cannot use a key twice.

blackboxlogic commented 4 years ago

Is there anything I can do to help this forward?

blackboxlogic commented 3 years ago

I'm still hoping for your consideration on https://github.com/ltog/osmi-addresses/pull/119 -Alex