Importing an existing wallet should help with mnemonic phrase validation

ltonetwork / lto-wallet

LTO Network web wallet

4 stars 37 forks source link

Importing an existing wallet should help with mnemonic phrase validation #135

Open sbrekelmans opened 3 years ago

sbrekelmans commented 3 years ago

In the tech support chat, we get a lot of wallet import questions that relate to typos, casing, spaces, trailing or otherwise. It would help a great deal if importing an existing seed would have a BIP39 validation, that would give a warning to the user before opening the corresponding wallet/address.

When a user imports a wallet that doesn't conform to BIP39 standard, a warning could be given to allow the user the possibility to check for errors before continuing. ("import is not a valid bip39 phrase, continue anyway?" for example)

jasny commented 3 years ago

The LTO Seed phrase isn't compatible with BIP39. It's an unfortunate side effect of forking Waves. https://medium.com/wavesprotocol/hd-wallet-creation-with-waves-39371d29d7bd

We should change this, but it (of course) must be backward compatible with the current seed phrases.

sbrekelmans commented 3 years ago

Fine, the end goal is to help users by warning about preventable mistakes. I think we could verify and warn when a user tries to import (among others):

seed words with capital letters
phrases with leading or trailing spaces
more than1 space in between words
words not on the word list
non-default word seed phrase length (so any other amount than 15 words)

All these issues change the phrase I believe (ie result in a different address).

justmvg commented 3 years ago

Enhancements on importing an existing seed have been pushed with PR #156

Would that be sufficient enough to close this issue?

@sbrekelmans @jasny