search

ltonetwork / mongodb-rest

JSON REST server for MongoDB (using node.js)
MIT License
405 stars 143 forks source link

query string #3

Closed 5at closed 13 years ago

5at commented 14 years ago

using a query string with a GET /db/col isnt working. Debugging the code it appears that in rest.js code uses req.params to extract the parameters passed within the url's query component (the bit after the "?" of a url). Shouldnt it be using req.query object instead to get to any of the parameters of the url's query component? (kinda confusing since "query" is used as a parameter name within the url's query :) )

This is for both req.params.query and req.params.option lines. i.e. They should be req.query.query and req.query.option respectively.

Also since they are strings should they not also be evaled or json.evaled before being passed to find() ?

tdegrunt commented 14 years ago

You're absolutely right, thank you! This is something that changed between 0.5 and 0.6 and I missed it.

So, just committed the change to look at the req.query.query's query query and this should fix it ;)

tdegrunt commented 14 years ago

Shouldn't have closed this too quickly, it's your ticket. Do you think it's sufficiently resolved?

tdegrunt commented 13 years ago

Closing it now ...