search

ltribolet / Lychee

A great looking and easy-to-use photo-management-system you can run on your server, to manage and share photos.
MIT License
0 stars 0 forks source link

[Enhancement] Add Conventional Commits #60

Open ltribolet opened 4 years ago

ltribolet commented 4 years ago

Adding this https://github.com/ramsey/conventional-commits

So we would follow https://www.conventionalcommits.org/en/v1.0.0/

But it would mean dropping Gitmoji I think.

sanghin commented 4 years ago

Do you have something like semantic-release on PHP? If so a commit linter would be necessary

ltribolet commented 4 years ago

Those are 2 different things. This is for commit message formatting enforcement. While Semantic Release appears to build the release package. While I understand that Semantic release is based on commit messages, I see those 2 being different. I am not aware of such tool dedicated to PHP.

sanghin commented 4 years ago

Yes they are different tools but if a semantic-release like module exist on php, you will need to have a commit message enforcement tool so you can generate changelog reliably, that was my point 😄

ltribolet commented 4 years ago

This is not something planned at the moment. But I'm not sure a tool like Conventional Commits and Semantic Release would be compatible for instance.

Edit: Apparently you can choose your own format https://github.com/semantic-release/semantic-release#commit-message-format So I guess why not :smile: