Closed parth-paradkar closed 4 years ago
Hello @thescriptninja! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
music_metadata_extractor/sources/youtube/core.py
:Line 12:1: W293 blank line contains whitespace Line 16:1: W293 blank line contains whitespace
music_metadata_extractor/sources/youtube/scraper.py
:Line 16:1: E302 expected 2 blank lines, found 1 Line 22:9: E722 do not use bare 'except' Line 23:80: E501 line too long (100 > 79 characters) Line 29:1: W293 blank line contains whitespace Line 55:80: E501 line too long (92 > 79 characters) Line 63:80: E501 line too long (98 > 79 characters) Line 67:80: E501 line too long (115 > 79 characters) Line 78:80: E501 line too long (86 > 79 characters) Line 93:10: W292 no newline at end of file
tests/test_songdata.py
:Line 82:80: E501 line too long (83 > 79 characters)
Damn, forgot to add dependencies
Really confused about the dependency issue in the build
@ghostwriternr Added changes to the tests but CI is failing since Github Actions is not finding the Google environment variable :confused: Don't really know how this works exactly :grimacing:
Merging this :crossed_fingers:
This will add methods to fetch information like date, views and title (earlier methods to scrape the html was breaking the code).