search

lttng / lttng-scope

A trace viewer and analyzer for LTTng kernel and user space traces
https://lttng.org/beta/#lttng-scope
Eclipse Public License 1.0
28 stars 6 forks source link

Current selection blue rectangle top and bottom delimiter could be invisible #66

Open PSRCode opened 6 years ago

PSRCode commented 6 years ago

Might be event better to simply fall back to the background blue and drop the delimiter altogether in case of range selection. In case of single click (0 delta range) we can fallback to a solid blue.

ghost commented 6 years ago

Are you talking about a view in particular?

I honestly do not hate it in the timegraph, because it helps see where the top and bottom of the scrollable pane are. It does look a bit off in the XY charts though...

Might be event better to simply fall back to the background blue and drop the delimiter altogether in case of range selection.

That's another possibility, but the solid border helps differentiate between an ongoing, unapplied-yet selection (before you release the mouse button), and a real one.

PSRCode commented 6 years ago

All views except the event table.

I honestly do not hate it in the timegraph, because it helps see where the top and bottom of the scrollable pane are. It does look a bit off in the XY charts though...

This is the responsibility of the scroll bar to the right. Adding an animation on the end and top when moving would be a better UI fit in the end if we do want to provide this kind of feedback.

That's another possibility, but the solid border helps differentiate between an ongoing, unapplied-yet selection (before you release the mouse button), and a real one.

I trust the user for knowing when it's selection is done aka when he is releasing the button. I would also argue if we follow this logic it would be more pertinent to have the border on during the selection action and remove it when it is done. Giving more focus on the action at hand end fade in when the action is done.

In all cases, this is NOT a release blocker.