search

ltwlf / json-diff-ts

A diff tool for JavaScript written in TypeScript.
MIT License
77 stars 24 forks source link

Update unflattenChanges regex #134

Closed andrewkucz closed 4 months ago

andrewkucz commented 7 months ago

Meant to address this issue I made yesterday: https://github.com/ltwlf/json-diff-ts/issues/133

I replaced the split regex with the regex found here: https://stackoverflow.com/questions/732029/how-to-split-string-by-unless-is-within-brackets-using-regex , replacing the comma with a period, and added a couple tests

sonarcloud[bot] commented 7 months ago

Quality Gate Failed Quality Gate failed

Failed conditions

1 Security Hotspot

See analysis details on SonarCloud

ltwlf commented 4 months ago

Thanks for the PR. The quality gates failed because the Regex. I have fixed the issue in #141