search

ltwlf / json-diff-ts

A diff tool for JavaScript written in TypeScript.
MIT License
81 stars 25 forks source link

Remove additional condition for different value types #86

Closed aszydlowska closed 1 year ago

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

aszydlowska commented 1 year ago

I've made this change because I thought it can help with this issue: https://github.com/ltwlf/json-diff-ts/issues/68

yadue commented 1 year ago

@ltwlf can you take a look?

aszydlowska commented 1 year ago

No longer needed

r-ohan commented 5 months ago

@aszydlowska do you mind explaining why you closed this PR? AFAIK this issue still persists?

aszydlowska commented 5 months ago

@r-ohan during tests it was causing more problems for us.