ltzehan / pe

0 stars 0 forks source link

Wrong use of actor in sequence diagram #17

Open ltzehan opened 1 year ago

ltzehan commented 1 year ago

In many sequence diagrams, the Actor is represented as a component (block); ref. In any case, instead of it may be more appropriate here to replace Actor with Sniff here, as it is the class that calls the executeCommand. Otherwise, it may be more appropriate to replace executeCommand with something more abstract such as "user supplies command"

image.png

soc-se-bot commented 1 year ago

Team's Response

We used minimal notation consistently. But the sniff suggestions seems appropriate

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: This is not merely about consistent use of minimal notation -- the Actor (the user in this case) is an entity that is interacting with the system and is not part of it. Illustrating it as a component is confusing especially since the outgoing arrow seems to additionally imply that Actor is a component of the system.