cargo-c 0.10.4 is not buildable on Rust 1.78 & 1.79

lu-zero / cargo-c

build and install C-compatible libraries

MIT License

446 stars 55 forks source link

Open AJIOB opened 1 week ago

AJIOB commented 1 week ago

orion-rs published their version 0.17.7 with MSRV 1.80 & it breaks clean builds.

Please, provide the Cargo.lock file for building on MSRV of your project (aka 1.78).

P.S. Looks like lots of previous releases cannot be built too

lu-zero commented 1 week ago

if you use cargo install --locked it does not work?

lu-zero commented 1 week ago

Also this project is not related at all with orion-rs since they do not seem to provide a C-ABI. I guess github glitched.

AJIOB commented 1 week ago

This project indirectly depends on orion-rs. As you know, Rust builds all the dependencies locally.

I've tested in the clear local docker environment, it's not a GitHub bug.

For calling cargo install --locked your repository must provide Cargo.lock file. For now, it doesn't do it. And I suggestes you to do it.

Please, try to call cargo install cargo-c inside the clear rust:1.78 docker/podman image. You will see that's I'm talking about.

lu-zero commented 1 week ago

Ok, now I see the problems

lu-zero commented 1 week ago

there are 2 issues:

I did not bump the msrv to match cargo (my fault), I'll publish this weekend a version with it fixed.
orion-rs bumped their mrsv, but since I did not bump the msrv using --locked you still see problems

In general I suggest to use the cargo-c matching the cargo version in use, so

cargo +1.78 install cargo-c@0.10.2 --locked

Does solve your problem.