search

lu-zero / cdylib-link-lines

Helper to build correctly cdylibs
MIT License
16 stars 5 forks source link

fix: Make #3 work on Rust < 1.53. #4

Closed Hywan closed 3 years ago

Hywan commented 3 years ago

The or-pattern is stable since Rust 1.53. This PR makes it works prior Rust 1.53.

(sequel of #3)

Hywan commented 3 years ago

I've added another patch to clean up/simplify the code a little bit. I hope it's OK.

lu-zero commented 3 years ago

It is very welcome, does it work for you with this set?

lu-zero commented 3 years ago

I just checked, the or-pattern is present in the current stable, if you have the information could you update the commit message with the minimum rust version?

Hywan commented 3 years ago

It's from Rust 1.53, https://blog.rust-lang.org/2021/06/17/Rust-1.53.0.html#or-patterns.

lu-zero commented 3 years ago

Thank you a lot!

Hywan commented 3 years ago

Thank you! One last question (not urgent): When can we expect a new release :-)?

lu-zero commented 3 years ago

I'm preparing it now :)

Hywan commented 3 years ago

Perfect!