Instead of storing patches inside the script, allow the user to supply patches themself

luarocks / hererocks

Python script for installing Lua/LuaJIT and LuaRocks into a local directory

MIT License

71 stars 12 forks source link

Instead of storing patches inside the script, allow the user to supply patches themself #10

Open averms opened 3 years ago

averms commented 3 years ago

I can't be the only one who thinks storing a patch inside a string is not ideal. On top of that, the script is not up-to-date with all the patches from https://www.lua.org/bugs.html. Plus, I might want to apply one of the Lua Power Patches. Overall, I think the cleaner solution is to deprecate the --patch option for something like --apply {names}

Erutuon commented 3 years ago

I don't know about removing the patches currently stored, but it would be nice to be able to apply the Advanced Readline Patch, particularly to LuaJIT or Moonjit, because the REPL is a pain to use without the arrow keys working properly.