search

luarocks / hererocks

Python script for installing Lua/LuaJIT and LuaRocks into a local directory
MIT License
71 stars 12 forks source link

Use HTTPS when downloading Lua & LuaRocks #14

Closed carlsmedstad closed 2 years ago

carlsmedstad commented 3 years ago

I'm having trouble using hererocks when building a docker image. I believe this is related to HTTP being used and that somehow messing up the routing.

The Dockefile:

FROM centos:7

# Dependencies to hererocks.
RUN yum install -y \
    gcc-4.8.5 \
    unzip-6.0 \
    make-3.82 \
    python3-3.6.8 \
    && yum -y clean all

RUN pip3 --no-cache-dir install \
    hererocks==0.23.0

RUN hererocks --no-readline --lua 5.3.6 --luarocks 3.5.0 /opt/lua

The URL changes I've done here resolves my issue. Is there a reason for keeping any of the HTTP URLs?

hishamhm commented 2 years ago

You're right, no particular reason to use plain HTTP there. Thanks for the patch!