luarocks / hererocks

Python script for installing Lua/LuaJIT and LuaRocks into a local directory
MIT License
71 stars 12 forks source link

Bug in test suite? #25

Closed gwerbin closed 9 months ago

gwerbin commented 9 months ago

The test TestCLI.test_verbose_install_bleeding_edge_luajit_with_latest_luarocks is failing with the following output mismatch:

E                   AssertionError: Expected to see 'b'LuaJIT 2.1.0'' in output of command 'test/here/bin/lua -v', got output:
E                   b'LuaJIT 2.1.ROLLING -- Copyright (C) 2005-2023 Mike Pall. https://luajit.org/\n'

This seems like an unintentional failure. As far as I can tell, the test is succeeding: Hererocks is correctly installing the requested version, and the lua command appears to be running the correct program. It seems like this assertSuccess method needs to be adapted somehow to accommodate a prefix match, or the output from lua -v needs to be truncated.

un-def commented 9 months ago

Good catch!

LuaJIT recently switched to the rolling release scheme:

See LuaJIT commits:

A fix is on the way.

gwerbin commented 9 months ago

Thanks! It's worth noting that this actually broke installation from AUR with Yay, because the Arch packaging tools run the test suite by default.

For anyone reading this between now and when the fix is released:

yay -S --mflags --nocheck hererocks