Add a Social Sign Up - Githubissues

luarocks / luarocks-site

LuaRocks website and module host

http://luarocks.org

175 stars 38 forks source link

Closed aajjbb closed 6 years ago

aajjbb commented 7 years ago

Points to pay attention when implementing the Github login

someone already has an account with the same username, need to give them a different username
someone already has an account with the same email. probably best to just abort it and tell them to link github after logging in
someone has an account already linked to that github account, you could just log them in

aajjbb commented 6 years ago

Closed by #113 and #116