search

luarocks / luarocks-site

LuaRocks website and module host
http://luarocks.org
175 stars 38 forks source link

[WIP] Follow/Star module distinction #114

Closed aajjbb closed 6 years ago

aajjbb commented 6 years ago

Hi, This PR aims to add a distinction between following and starring a module. Similarly to Github, starring a module should be an action of liking the module content and following a module means one wants to follow the changes and discussions about a module. The goal here is to add that same feature to luarocks.

aajjbb commented 6 years ago

Some tests are failing and it's because of the spec.factory.Following. We have to add a kind field to the Following object generated, but the kind is variable and the tests cover both cases. Should we add an argument to the generating function so we can choose the kind of following it has ?

leafo commented 6 years ago

Made a few minor changes, renamed kind -> type, and this stuff: https://github.com/luarocks/luarocks-site/commit/e435a22b48a0489887b587a38998d1df43077c4f

I rebased your branch manually instead of merging to keep history clean