luarocks / luarocks-site

LuaRocks website and module host
http://luarocks.org
175 stars 38 forks source link

Use GitHub email api to get email address of user #115

Closed leafo closed 6 years ago

leafo commented 6 years ago

user.email is only available if the account has a publicly listed email address. You'll need to use the emails api endpoint to fetch the email address: https://developer.github.com/v3/users/emails/

I added a temporary message but we should fetch their email so anyone can log in: https://github.com/luarocks/luarocks-site/blob/2ad70c3e59dceaa61225f875e1e74579f4a1ef07/applications/github.moon#L73

aajjbb commented 6 years ago

somehow the commit that address this issue is in the #114. I don't know how this happened.

leafo commented 6 years ago

aajjbb do you want to pull the commit out into seprate pull request?

aajjbb commented 6 years ago

This seems much wiser.

aajjbb commented 6 years ago

Closed via #116