search

luarocks / luarocks-site

LuaRocks website and module host
http://luarocks.org
176 stars 36 forks source link

label doesn't get picked up from rockspec #188

Open teto opened 2 years ago

teto commented 2 years ago

For all the rockspecs at https://luarocks.org/labels/neovim, I've had to manually add their tag on the website even though I've specified it in the rockspec. Typically: 

description = {
    summary = "A completion plugin for neovim",
    labels = { "neovim" },
    detailed = [[
    A completion engine plugin for neovim written in Lua. Completion sources are installed from external repositories and "sourced".
   ]],
    homepage = "https://github.com/hrsh7th/nvim-cmp",
    license = "MIT",
}

I would like to add a template rockspec to https://github.com/nvim-lua/nvim-lua-plugin-template so I would like if it's my way of specifying the labels that is wrong or if it's a website bug ?

hishamhm commented 2 years ago

I don't know for sure, @leafo will know better, but I think what happens is that the metadata, including labels, is only picked up the first time you upload a rockspec, and not for each subsequent release... it would probably make sense for it to pick it up from the latest one, but whether this behavior is easy/hard to change, I don't know!

teto commented 2 years ago

Thanks for the answer :) In my case it fails also the first time.

leafo commented 1 year ago

I believe the labels functionality on the site was developed at a separate time from when labels were made available on the rockspec format, so they are currently not used. You will have to currently manually set the labels on the web interface for the module