luarocks / luarocks-site

LuaRocks website and module host
http://luarocks.org
176 stars 36 forks source link

How to deal with "faulty" unmaintained packages #199

Closed teto closed 1 year ago

teto commented 1 year ago

This is a general question, for haskell for instance some special maintainers can amend packages in case the author went missing https://wiki.haskell.org/Hackage_trustees .

I have 2 cases in mind:

teto commented 1 year ago

I wanna add another one (I've just noticed the mainainer yesterday so it might not be unmaintained). Installing from workspec https://luarocks.org/modules/peterbillam/readline/3.3-0 fails because of certificates issues see https://github.com/peterbillam/muscript/issues/3 for more details.

cc @hishamhm for the first post issues since I think you uploaded both

Tieske commented 1 year ago

@teto most modules uploaded by "luarocks" are unmaintained rocks that the luarocks team had the courtesy for to upload by themselves to keep them available. However that doesn't mean Luarocks is now in some way responsible.

I noticed for the lua-mimetypes that @tst2005 also has a github clone. So we could move it to lunarmodules and set up a team with the 2 of you as maintainers.

teto commented 1 year ago

I didn't know about lunarmodules and that looks great for this usecase, note that I've created also a clone https://github.com/teto/lua-mimetypes/ (with the unzipped rock). I would be glad to transfer it to lunarmodules. Something that I find odd though is that lunarmodules seems to reference alive projects such as https://github.com/lunarmodules/busted while the disclaimer mentions only unmaintainted projects ?

If possible I would also like to put lua https://luarocks.org/modules/luarocks/lua-iconv under lunarmodules.

Once in lunarmodules, how does the upload to luarocks.org work ? do you give an API key or should I upload the rockspec under my own account ?

Tieske commented 1 year ago

Lunarmodules only provides governance, so most project there landed because their previous owners/maintainers handed them over. The lunarmodules team only does maintain the authorizations on github, the rest is on the maintainers.

For deployments to LuaRocks there are 2 modesl in use; set a secret in github and configure an automatic upload flow triggered on tags. Or have a apikey by one of the maintainers, who then uploads.

teto commented 1 year ago

Thanks to everyone involved, it should be fixed now ! Kudos to all

teto commented 1 year ago

arf I still have the issue with readline but finally managed to access gitlab (cloudflare sometimes goes into infinite loops for god knows what reason), and the author has been active lately so hopefully we can get to a solution https://gitlab.com/peterbillam/pjb_lua/-/issues/2

teto commented 1 year ago

trying to update the package set, I noticed that I had forked luabitop too (used in prosody apparently) so I followed the source and there is bunch of packages that are marked as archived from https://github.com/LuaDist. Shouldn't these be moved to lunarmodules as well ?

Tieske commented 1 year ago

LuaDist was a Lu adistribution based on cmake, that would also build the underlying lib, not only the binding.

They are typically not the source of the code, though they had many forks and updated them for cmake.

teto commented 1 year ago

seems like https://luarocks.org/modules/luarocks/readline is unneeded too since peter is active and updating https://luarocks.org/modules/peterbillam/readline. : pruning packages uploaded by luarocks "luarocks" can help see what is maintained