Lua Toolbox merge

[Etiene]

A brand new dump of LuaToolbox's db will be needed (cc @catwell)

For transferring endorsements to Followings I added a new tab on the user settings explaining the situation with a link for the transfer. I have an issue once the transfer is done though. I'm rendering the same view from a different action and this results on the url changing when you get the success message. I don't particularly like that but I didn't know how to do otherwise and this might need a touch-up. Not a huge deal, though.

When importing current labels I was not exactly sure how to access Lapis' model module in a simple script. So for the moment the functions are in a helper class and I tested and ran them using the specs.

I also added the labels to the front page, but I'm not sure if it's pretty enough.

For the moment only module owners can add or remove labels from a module. There's no way to add new labels yet, only to select from existing labels.

Screenshots of my local system:

|--> Owner's view: Add label link is on owner's menu for the moment

[catwell]

This is great. I still miss one of the main features from Toolbox though: the ability to see the list of modules endorsed / followed by someone and a list of people endorsing / following a module. If this isn't available then followings cannot replace endorsements.

The first one could be added below the list of modules authored by a user on their user page and the second one could be accessible by clicking here:

Regarding DB dumps, if I give you a dump and at a later time another one, can you apply the changes? I am starting to think about exactly when I should shut Toolbox down.

[Etiene]

the ability to see the list of modules endorsed / followed by someone and a list of people endorsing

oops! :) coming in soon :)

[catwell]

Awesome!

I am still wondering if "follows" and "endorsements" should be the same thing. On GitHub they are not (Follow would be Watch and Endorse would be Star). What do you think?

[Etiene]

I had this discussion with @leafo , the issue is that maybe this makes for too many verbs and features for the users to catch up for now and the current following feature doesn't do much for the moment, he suggested merging them up and I thought it was a good idea. @hishamhm suggested maybe we should rename the followings to something simpler, such as stars, so user engagement can come easier.

[catwell]

OK, it makes sense.

Regarding missing features, I also think that:

• Follow count should be visible in module lists (next to downloads)
• There should be a way to sort those lists by follows (and probably downloads too)

Regarding the transition, here is how I see it:

• Once this is ready, we decide on a date to shutdown Lua Toolbox.
• I will send an email to all Toolbox users, telling them that it is shutting down.
  • I will explain how it will be replaced by LuaRocks (including the import feature).
  • I will tell users to create accounts there if they haven't already.
• On the date we decided I will replace the Lua Toolbox website by a static page explaining this.
• I will generate a final DB dump that I will give you.

How does that sound?

[hishamhm]

Yes, my argument was that "follow" makes me think "no, I don't want to receive email notifications", while "stars" are vague enough so that in practice it has a community-defined meaning (see the old Twitter stars).

I also suggested that, if possible, it would be nice to import Github stars from a project and add them up with the "local stars". This would help populating project stars a lot. On Mar 17, 2016 17:11, "Etiene Dalcol" notifications@github.com wrote:

I had this discussion with @leafo https://github.com/leafo , the issue is that maybe this makes for too many verbs and features for the users to catch up for now and the current following feature doesn't do much for the moment, he suggested merging them up and I thought it was a good idea. @hishamhm https://github.com/hishamhm suggested maybe we should rename the followings to something simpler, such as stars, so user engagement can come easier.

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/leafo/luarocks-site/pull/86#issuecomment-198061561

[Etiene]

@catwell sounds perfect to me!

[leafo]

Thanks for the patch, I did a quick code review. Tell me if you have any questions. Didn't get a chance to run the code and check out the UI yet.

I named the functionality follow because to me that says you'd like to follow the changes/updates of the module. I planned to have some sort of feature where it would give you a digest page on the site of modules you follow that got updated, and an optional email when new versions of modules you follow are released.

I think having github stars displayed could be a great way for someone browsing modules to identify what's used, but not sure about he complexities in keeping in synchronized.

[leafo]

Are you planning on making these changes @Etiene? I know your time is limited for this project, no need to rush, just curious.

[Etiene]

the time for the project is up, had to shift to report writing, but I will make these changes! :)

[Etiene]

Sorry for the delay! Finishing masters, moving to a different country and stuff!

@leafo I've made a refactor following most of your suggestions. I'll need help with some of them, though, I'll reply to those one by one. Could you take another look now?

@catwell I'll start working on your suggestions now

[leafo]

Alright! Sorry for the huge delay. I've merged in your changes. I hope you don't mind but I ended up refactoring things a bit to simplify the model structure. Labels are stored right on the module with an postgres array type. I also moved the label stuff into a new application, and added tests.

I've hidden the endorsement -> follows stuff at the moment. Once I get the data dump I can test running it, then add it back.

Thanks for your help getting this stuff done, sorry for the slow turnaround time.

@catwell could you email me that dump when you get a chance?

Thanks

[catwell]

@leafo email sent.

[Etiene]

No, dont worry, thank you! I'm sorry it took me ages to reply as well and I didn't have the time to go through all your suggestions! I'm really glad this is happening! 👯

[catwell]

I have seen that this is merged, awesome!

All that's missing for me now is:

• follows count on module summaries;
• ability to sort module lists by endorsements or by follows.

I will set Lua Toolbox read-only and point users to LuaRocks as soon as I find the time. (EDIT: done)