Fixes for Celery - Githubissues

luau / UniversalSynSaveInstance

Shortly USSI. A universal saveinstance revival. This can also be edited and used as a Roblox-Format-File writer.

https://luau.github.io/UniversalSynSaveInstance/

Other

86 stars 36 forks source link

Fixes for Celery #27

Closed centerepic closed 4 months ago

centerepic commented 4 months ago

This implements some fixes for Celery.

Celery's gethiddenproperty is incredibly slow and doesn't work, it's fake. I made it assume gethiddenproperty is nil if you're on Celery as it functionally is and slows everything to a crawl.
Celery's file apis, for whatever reason have an arbitrary file size limit of around 4 MB, so I re-enable a slightly modified version of the appendfile loop you commented out if the executor is Celery.

I have tested the changes and they seem to work.

wally2471 commented 4 months ago

Pasted

centerepic commented 4 months ago

Pasted

ur pasted

centerepic commented 4 months ago

I've since spoken with the owner of celery, a fix for the issues (at least gethiddenproperty) is planned so this update probably won't be necessary depending on how long it takes to actually implement and if file saving gets fixed too.

phoriah commented 4 months ago

Thanks. I have to warn you though, appendfile can sometimes absorb data under heavy load on certain executors.

phoriah commented 4 months ago

It would be much better if Celery fixed these on their end, because Solara handles it just fine.