search

luavixen / damagenumbers

Minecraft mod that adds simple damage number particles.
https://modrinth.com/mod/damagenumbers
1 stars 0 forks source link

Remove Requirement Of Library? #6

Open ExiledLizard opened 2 weeks ago

ExiledLizard commented 2 weeks ago

Hey, @luavixen, since I don't really like to install libraries, could you upload a version of your mod (as an external link, in this issue), for FABRIC: "Damage Numbers", that doesn't have a config screen, therefore, the damage colors are set to default (by you)? Or this requires a big rewrite, so no?

luavixen commented 2 weeks ago

I have made a new commit that removes the hard dependency on YACL. Attempting to open the config screen without YACL will result in this message being displayed to the user: Screenshot

I will release version 1.2.0 of Damage Numbers with this change soon, but it may take some time for the new update to be approved. In the meantime, you can download the update below. Fabric: https://dl.vixen.link/h3n99k/damagenumbers-1.2.0-fabric.jar Forge: https://dl.vixen.link/c3dhwy/damagenumbers-1.2.0-forge.jar

Does this work for you? I've had a few suggestions that YACL is a nuisance.

ExiledLizard commented 2 weeks ago

Thanks for responding! When I come back from school to my house, I'll download & drag the (updated) mod in the mods folder, so I'll see if it works then.

On Tue, Apr 16, 2024 at 9:28 PM Lua MacDougall @.***> wrote:

I have made a new commit https://github.com/luavixen/damagenumbers/commit/e6c3e1913a5cd136995d4e4f489df8d448535733 that removes the hard dependency on YACL. Attempting to open the config screen without YACL will result in this message being displayed to the user: image.png (view on web) https://github.com/luavixen/damagenumbers/assets/7506308/afc60524-21cf-4341-8a18-d9b2daa65c1a

I will release version 1.2.0 of Damage Numbers with this change soon, but it may take some time for the new update to be approved. In the meantime, you can download the update below. Fabric: https://dl.vixen.link/h3n99k/damagenumbers-1.2.0-fabric.jar Forge: https://dl.vixen.link/c3dhwy/damagenumbers-1.2.0-forge.jar

Does this work for you? I've had a few suggestions that YACL is a nuisance.

— Reply to this email directly, view it on GitHub https://github.com/luavixen/damagenumbers/issues/6#issuecomment-2060320782, or unsubscribe https://github.com/notifications/unsubscribe-auth/A7XKI7T3WVTMLHVN2GL3AYLY5X257AVCNFSM6AAAAABGKITC7CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRQGMZDANZYGI . You are receiving this because you authored the thread.Message ID: @.***>

ExiledLizard commented 2 weeks ago

@luavixen, I just ran the mod, and it was installed properly, but when I hit an entity, the mod crashed my client :( - here's the crash report, so that you could fix the mod: crash-2024-04-17_17.07.30-client.txt