lubeda / EspHoMaTriXv2

A simple DIY status display with a 8x32 RGB LED matrix, implemented with esphome.io and Home Assistant.
MIT License
297 stars 28 forks source link

2023.9.1: Add Bitmap Stack screen #140

Closed andrewjswan closed 12 months ago

andrewjswan commented 12 months ago

https://github.com/lubeda/EspHoMaTriXv2/issues/139

lubeda commented 12 months ago

What about the readme? Why did you change calc scroll time?

andrewjswan commented 12 months ago

I dont change, only add new for icons

    void calc_scroll_time(std::string text, uint16_t screen_time);
    void calc_scroll_time(uint8_t icon_count, uint16_t screen_time);

Readme updated ...

lubeda commented 12 months ago

Hi, its a nice effect but the |two "parameter" isn't a clean way to pass parameters and the functionality isn't described in the readme.

andrewjswan commented 12 months ago

I added 2 examples at the bottom of the Readme, I just don't quite understand how to describe it clearly, should see the effect working on the 1,2,3 icon.