andrewjswan
commented
10 months ago Doesn't find the clock screen when the alert screen has been removed. https://github.com/lubeda/EspHoMaTriXv2/blob/2023.9.1/components/ehmtxv2/EHMTX.cpp#L798 The reason is:
this->queue[this->screen_pointer]->last_time = ts + this->queue[this->screen_pointer]->screen_time_;Showed the clock screen in 20:01:32:
[20:01:32][D][EHMTXv2:122]: queue: icon clock: "day#1" for: 10.0 sec
[20:01:32][D][EHMTXv2:1018]: on_next_screen triggerthis->queue[this->screen_pointer]->last_time = 20:01:42; Showed an alert screen and deleted it in 20:01:38:
[20:01:38][D][EHMTXv2:851]: remove expired queue element: slot 1: mode: 16 icon_name: spotify text: Song name - Artist nameAnd we didn’t find the clock screen because the condition is not met:
if ((this->queue[i]->endtime > this->get_tick()) && (this->queue[i]->last_time < last_time))Ie:
- this->queue[i]->endtime > this->get_tick() - True
- this->queue[i]->last_time < last_time - False - 20:01:42 < 20:01:38
There are constant skipping cycles until the above condition is met (in 20:01:42), and then we start showing the screens:
[20:01:42][D][EHMTXv2:790]: oldest queue element is: 0/1
[20:01:42][D][EHMTXv2:122]: queue: icon clock: "day#1" for: 10.0 sec
[20:01:42][D][EHMTXv2:1018]: on_next_screen triggerI propose a solution: If we haven’t found any old screens, but our queue is not empty, return the first one from the queue to display. https://github.com/lubeda/EspHoMaTriXv2/blob/2023.9.1/components/ehmtxv2/EHMTX.cpp#L804-L807 Change to:
uint8_t queue_count = this->queue_count();
if (hit != MAXQUEUE)
{
ESP_LOGD(TAG, "oldest queue element is: %d/%d", hit, queue_count);
}
else if (queue_count > 0)
{
hit = 0;
ESP_LOGD(TAG, "oldest queue element is first: %d/%d", hit, queue_count);
}
chertvl
Bug report
Describe the bug
For example, I have only one clock screen with lifetime 1440, screentime 10. I called Alert Screen service with some parameters. After Alert is showed it must auto-deleted from queue, and after auto-delete screen I have very huge log storm with strange symbols for 3-4 seconds (many times per second). Somewhy my clock screen dissapears from queue and its empty now, on_empty_queue is trying to add a clock screen again but cant do it few seconds.
On Ulanzi display I see last frame of screen wich must be deleted, it freeze for 1-2 sec, then screen and logs both back to normal.
Additional information
Configuration
Logs