search

lubeda / EspHoMaTriXv2

A simple DIY status display with a 8x32 RGB LED matrix, implemented with esphome.io and Home Assistant.
MIT License
276 stars 25 forks source link

2023.9.1: Add Height to Icon Indicator #183

Closed andrewjswan closed 8 months ago

lubeda commented 8 months ago

Hi, wouldn't it be nicer to change the order of the parameters to: void EHMTX::show_icon_indicator(int r, int g, int b, int size, int pos, int height)

I think this is a bit less "breaking"

andrewjswan commented 8 months ago

One minute ...

andrewjswan commented 8 months ago

I think this is a bit less "breaking"

Changed ...