Closed jfurtner closed 1 year ago
i check this in two weeks after my holiday
I initially thought the indicator was broken, it not showing on top of the clock was quite unexpected. You may want to consider showing it everywhere by default :)
Hi, i will take a look this weekend. But I think the left indicator is quite intrusive with icons, so I prefer my way. But there is general caveat in your pull request.
Hi, i have problems in merging this PR because the diff of the ehmtx.cpp and the init.py don't show the differences. Instead, they seam to be a complete replacement of the original files.
Interesting. I’ll check, likely line end differences. On Jul 16, 2023, at 9:05 AM, LuBeDa @.***> wrote: Hi, i have problems in merging this PR because the diff of the ehmtx.cpp and the init.py don't show the differences. Instead, they seam to be a complete replacement of the original files.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>
The diff shows the changes correctly. Now to figure out what settings I've got wrong in VS Code.
Tomorrow i will include your code to develop
is merged to develop
Thanks @lubeda
Added config entry and changes to draw() function, just ifdef'd around current if clauses to match current behaviour by default.
I wanted to be able to show rl indicators on any screen (including clock/date).