search

luben / load-progress-bar

Minimalistic load progress bar addon for Firefox
BSD 2-Clause "Simplified" License
29 stars 3 forks source link

Opacity incompatibility with Dark Reader add-on in Firefox. #19

Open Kratorator opened 1 year ago

Kratorator commented 1 year ago

Even with Opacity set at maximum, it is still (maybe 50%?) transparent when used with Dark Reader, in both Dark and Light mode. I also posted an issue in https://github.com/darkreader/darkreader.

Maybe you two could communicate about this (small) problem.

luben commented 1 year ago

Yes, the min opacity is 25%: https://github.com/luben/load-progress-bar/blob/master/settings/options.html#L39 - this does not depend on darkreader or not.

Can I ask why you want opacity to be lower?

Kratorator commented 1 year ago

Hi,

I want FULL opacity when it's set at full opacity! (no transparency)

Bye,

chrr

On 18.06.23 23:27, luben karavelov wrote:

Yes, the min opacity is 25%: https://github.com/luben/load-progress-bar/blob/master/settings/options.html#L39 https://github.com/luben/load-progress-bar/blob/master/settings/options.html#L39 - this does not depend on darkreader or not.

Can I ask why you want opacity to be lower?

— Reply to this email directly, view it on GitHub https://github.com/luben/load-progress-bar/issues/19#issuecomment-1596274030, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD4BFHKEXH4SOXN4TG5PFNDXL5XDNANCNFSM6AAAAAAZJ34X6Y. You are receiving this because you authored the thread.Message ID: @.***>

luben commented 1 year ago

Yes, but why? If we allow full opacity the progress bar will not show at all. This will lead to users complaining that the add-on does not work.

Kratorator commented 1 year ago

JHCOAFRC

It seems that you confuse opacity with transparency.

When I drag the slider for Thickness all the way to the right, it is at 100% thickness, right? so when I drag the slider for Opacity all the way to the right, it's at 100% opacity, right?

Opacity is the opposite of transparency. 100% OPACITY = 0% TRANSPARENCY = FULLY VISIBLE. 100% TRANSPARENCY = 0% OPACITY = invisible.

I want the Load Progress Bar to be FULLY VISIBLE, so I drag the slider to 100% OPACITY. It works fine WITHOUT Dark Reader.

My progress bar color is RGB(255, 255, 0) which is fluo yellow. Very visible. If I turn ON Dark Reader, that yellow is NOT FULLY OPAQUE (=not 100% opacity), even though the opacity slider IS at 100% opacity, all the way to the right. The progress bar is the color of sick old mustard, because it is partly opaque (maybe 60%) and partly transparent (maybe 40%). This only happens when Dark Reader is active.

Ciao,

chrr

On 19.06.23 13:04, luben karavelov wrote:

Yes, but why? If we allow full opacity the progress bar will not show at all. This will lead to users complaining that the add-on does not work.

luben commented 1 year ago

Hmm, yes, I was confusing the opacity/transparency. Looked at the code - it sets it to 100%. Tried it in combination with the darkreader extension and indeed the color looks muted. On closer inspection, the dark-reader installs a global style and I guess that also affects the color of the progress bar. I still cannot figure how it does that and is it possible to work around it.