search

luben / zstd-jni

JNI binding for Zstd
Other
808 stars 165 forks source link

Migrate supported java version from 1.6 to 1.8 #281

Closed Hamlin-Li closed 8 months ago

Hamlin-Li commented 8 months ago

Hi,

Can I have a discussion about the supported jdk versions of zstd-jni? In the build.sbt, jdk1.6 is still supported:

javacOptions ++= Seq("--release", "6", "-Xlint:unchecked")
...
doc / javacOptions := Seq("--release", "6")
...
OsgiKeys.requireCapability := "osgi.ee;filter:=\"(&(osgi.ee=JavaSE)(version>=1.6))\""

I'm not sure if this is necessary, but seems this blocks the usage of zstd-jni in jdk 17/21 and later?

$ javac -version
javac 17.0.2
hamlin@hamlin:~/workspace/tools$ javac --release 6 Test.java
error: release version 6 not supported
Usage: javac <options> <source files>
use --help for a list of possible options

Do we have a plan to migrate the supportted jdk version from 1.6 to 1.8? If positive, this is the pr to do it.

Thanks!

luben commented 8 months ago

Yes, I think we should update the minimum supported version.

Hamlin-Li commented 8 months ago

Thanks for your review!