luben / zstd-jni

JNI binding for Zstd
Other
808 stars 165 forks source link

Remove -march for riscv #283

Closed Hamlin-Li closed 8 months ago

Hamlin-Li commented 8 months ago

Hi, Can you review this simple change? It removes the -march argument when cross-compile riscv in make_so_cross.sh. This is to let the compiler to pick up the default arch, to enable most compatability on different hardwares. Thanks!

codecov-commenter commented 8 months ago

Codecov Report

Merging #283 (f327725) into master (1ab2d21) will decrease coverage by 0.15%. The diff coverage is n/a.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff              @@
##             master     #283      +/-   ##
============================================
- Coverage     59.88%   59.74%   -0.15%     
+ Complexity      302      301       -1     
============================================
  Files            26       26              
  Lines          1421     1421              
  Branches        164      164              
============================================
- Hits            851      849       -2     
- Misses          416      417       +1     
- Partials        154      155       +1     
luben commented 8 months ago

LGTM

Hamlin-Li commented 8 months ago

Thanks for your reviewing.