luben / zstd-jni

JNI binding for Zstd
Other
808 stars 165 forks source link

Please help to add CI support for riscv64 #284

Closed Hamlin-Li closed 8 months ago

Hamlin-Li commented 8 months ago

Hi, Currently riscv64 is supported by zstd-jni pr #282 .

It's tested locally, but not regularly on github. I tried to modify the ci script to enable the CI support for riscv64, but seems I don't have the right to do so. Can someone help to do it?

Thanks!

(Seems it's simple to enable it? I'm not sure, I did not modify this script before.)

diff --git a/.github/workflows/ci-qemu-cross.yml b/.github/workflows/ci-qemu-cross.yml
index e8df8fa..7c962f2 100644
--- a/.github/workflows/ci-qemu-cross.yml
+++ b/.github/workflows/ci-qemu-cross.yml
@@ -5,7 +5,8 @@ jobs:
         strategy:
             matrix:
                 include: [
-                    { platform: s390x }
+                    { platform: s390x },
+                    { platform: riscv64 },
                 ]
         runs-on: ubuntu-latest
         steps:
luben commented 8 months ago

I am not sure it's going to be so easy. I will try it

Hamlin-Li commented 8 months ago

Thanks Luben. Seem it's because when I generated my github access token, I did include the workflow. I can also try it later.

Hamlin-Li commented 8 months ago

I have created the https://github.com/luben/zstd-jni/pull/285. ( The reason I could not create the pr is because of wrong access token, sorry for the inconvenience. )